This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
CI: Use the docker -f flag instead of copying the Dockerfile #2541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forslund
added
the
CLA: Yes
|
Voight Kampff Integration Test Succeeded (Results) |
chrisveilleux
suggested changes
Apr 21, 2020
|
Dockerfile has been renamed as requested |
|
Voight Kampff Integration Test Succeeded (Results) |
forslund
changed the title
|
Voight Kampff Integration Test Succeeded (Results) |
forslund
force-pushed
the
bugfix/jenkins-file-no-dockerfile-copy
branch
from
be26c9a
to
ff1f072
Compare
|
Voight Kampff Integration Test Succeeded (Results) |
|
@chrisveilleux I rebased this resolving the conflict. Anything else you'd like to change? |
|
LGTM - @chrisveilleux I'll merge it on Monday unless there's anything else that needs addressing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace the Dockerfile copy step with building the Docker container with -f test/Dockerfile
How to test
Check that the VK test passes.
Contributor license agreement signed?
CLA [ Yes ]