Refactor/settings cleanup #2560
Conversation
devs-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Succeeded (Results) |
forslund
force-pushed
the
refactor/settings-cleanup
branch
from
8ef3437
to
0d1b984
Compare
|
Voight Kampff Integration Test Succeeded (Results) |
mycroft/skills/settings.py
Outdated
| 'mycroft.skills.settings.changed', | ||
| data={skill_gid: remote_settings} | ||
| ) | ||
| message = Message('mycroft.skills.settings.changed', |
There was a problem hiding this comment.
This change would be overwritten by Black. You should just run Black on this module, as with any module we check in.
There was a problem hiding this comment.
Ok good to know, I'll revert this change.
There was a problem hiding this comment.
I'll leave complete blacking out this time since we should probably discuss which settings Black should use before starting to move from pycodestyle approved to black.
There was a problem hiding this comment.
The beauty of Black is that there really are no settings. It is overly opinionated so that we don't have to be. I don't agree with all the things Black does, but I put consistently styled code over my objections.
- Update docstrings - Remove unused members - Minor logic change to make download method more self-contained
forslund
force-pushed
the
refactor/settings-cleanup
branch
from
0d1b984
to
e0e5f7f
Compare
forslund
added
the
Merge after next release
|
Voight Kampff Integration Test Failed (Results) |
|
Voight Kampff Integration Test Succeeded (Results) |
Description
Clean up a couple of unused, parts of the settings system.
How to test
Make sure settings are still downloaded and updated on change on home.
Contributor license agreement signed?
CLA [ Yes ]