This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Explicitely run the messagebus test with Python 3 #2569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devs-mycroft
added
the
CLA: Yes
/usr/bin/python might not always point to Python 3, and it might not even exist, depending on the distribution. To make sure we always run with Python 3, explicitely call /usr/bin/python3 Also update the service start command and remove the outdated message method tests
|
Voight Kampff Integration Test Succeeded (Results) |
|
Thanks for updating this @PureTryOut, merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/usr/bin/pythonmight not always point to Python 3, and it might not even exist, depending on the distribution. For example Alpine Linux doesn't have/usr/bin/pythonpointing to/usr/bin/python3yet and since I have no Python 2 installed,/usr/bin/pythondoesn't exist at all. To make sure we always run with Python 3, explicitely call/usr/bin/python3This fixes #2570
How to test
Run the tests like before and see if the messagebus tests still pass.
Contributor license agreement signed?
CLA [x]