This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devs-mycroft
added
the
CLA: Yes
Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
label
May 11, 2020
forslund
reviewed
May 11, 2020
Voight Kampff Integration Test Succeeded (Results) |
Hi, now I'm curious about the requests requirement. Mycroft dev_setup.sh installs requests into it's venv using pip. Is it needed to have externally as well? |
@forslund thanks for your patience. I had issues with gentoo in docker so I started a VirtualBox gentoo Installation on Sunday.... I just confirmed dev-python/virtualenv is not required. |
Hi @doczkal if you're feeling happy with this at this stage I can merge it as soon as the conflict is resolved. |
Hi, any update on this? If you're not comfortable resolving the conflict I can do it for you if you like. Best
|
@forslund should be fixed now. |
Voight Kampff Integration Test Succeeded (Results) |
Sorry I missed this, but thanks @doczkal! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
CLA: Yes
Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have added support for Gentoo Linux to the dev_setup.sh script.
How to test
run dev_setup.sh on gentoo Linux
Contributor license agreement signed?
CLA [ yes]