Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

self.gui.show_animated_image #2616

Merged
merged 2 commits into from
Jun 15, 2020
Merged

self.gui.show_animated_image #2616

merged 2 commits into from
Jun 15, 2020

Conversation

JarbasAl
Copy link
Contributor

Adds some missing stuff from SkillGui docstrings

adds a new method and qml template to show animated images (gif files)

@JarbasAl JarbasAl added Type: Enhancement - proposed New proposal for a feature that is not currently a priority on the roadmap. GUI labels Jun 14, 2020
@JarbasAl JarbasAl requested a review from AIIX June 14, 2020 21:54
@pep8speaks
Copy link

pep8speaks commented Jun 14, 2020 •
edited
Loading

Hello @JarbasAl! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-06-14 21:55:43 UTC

@devops-mycroft devops-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Jun 14, 2020
@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results)

1 similar comment
@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results)

@forslund
Copy link
Collaborator

Good addition and docstrings are spot on. Also nice catch with the {} > None

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@AIIX
Copy link
Collaborator

AIIX commented Jun 15, 2020

+1 awesome works fine for me

@krisgesling
Copy link
Contributor

Excellent, thanks Jarbas, and everyone else for reviewing :)

@krisgesling krisgesling merged commit c90a1a5 into dev Jun 15, 2020
@AIIX AIIX mentioned this pull request Jun 15, 2020
Closed
@AIIX
Copy link
Collaborator

AIIX commented Jun 15, 2020

@krisgesling as per review this should have remained open, but since it was already merged, please find the revert / fix in the following PR #2617

AIIX
AIIX reviewed Jun 15, 2020
View reviewed changes
Copy link
Collaborator

@AIIX AIIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have fixed it in #2617

mycroft/enclosure/gui.py Show resolved Hide resolved
@krisgesling krisgesling deleted the feat/show_animated_image branch September 18, 2020 02:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AIIX AIIX AIIX left review comments

@forslund forslund forslund left review comments

Assignees
No one assigned
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) Type: Enhancement - proposed New proposal for a feature that is not currently a priority on the roadmap.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JarbasAl @pep8speaks @devops-mycroft @forslund @AIIX @krisgesling