Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

sleep after skills loaded for any final setup #2626

Merged
merged 1 commit into from
Jul 17, 2020
Merged

sleep after skills loaded for any final setup #2626

merged 1 commit into from
Jul 17, 2020

Conversation

krisgesling
Copy link
Contributor

This is a test to see if sleeping after a Skills report being loaded improves the stability of the first Voight Kampff tests in a Jenkins environment.

DO NOT MERGE

@krisgesling krisgesling added the Status: Work in progress PR being actively worked on, not yet ready for review. label Jun 30, 2020
@devops-mycroft devops-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Jun 30, 2020
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

2 similar comments
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results)

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

1 similar comment
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@krisgesling krisgesling removed the Status: Work in progress PR being actively worked on, not yet ready for review. label Jul 17, 2020
@krisgesling
Copy link
Contributor Author

As discussed in dev sync, I haven't had a date-time failure while the extra sleep here has been activated. However as the failure is so sporadic, this might be a coincidence.

To validate my assumption we're going to merge this and see if the issue arises anytime over the next few weeks. If it doesn't then there is indeed something that quite ready when the tests are initiated. If the test fails again, then the hypothesis is false and we can look elsewhere.

Either way we can then remove the sleep and be in a better position to find the underlying cause.

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@forslund
Copy link
Collaborator

Sounds good

forslund
forslund approved these changes Jul 17, 2020
View reviewed changes
Copy link
Collaborator

@forslund forslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge away :)

@krisgesling krisgesling merged commit 6f33cc0 into dev Jul 17, 2020
@krisgesling krisgesling deleted the bugfix/random-vk-fail branch September 2, 2020 21:02
krisgesling added a commit that referenced this pull request Oct 28, 2020
@krisgesling
revert a temporary bugfix from PR #2626
e0c7016
@krisgesling krisgesling mentioned this pull request Oct 28, 2020
Merged
1 task
krisgesling added a commit that referenced this pull request Jun 7, 2021
@krisgesling
Merge pull request #2741 from MycroftAI/bugfix/revert-vk-sleep
8a3cb6e 
revert a temporary bugfix from PR #2626
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@forslund forslund forslund approved these changes

Assignees
No one assigned
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krisgesling @devops-mycroft @forslund