This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Add wait_for_message method #2628

Merged

krisgesling merged 3 commits into MycroftAI:dev from forslund:feature/wait-for-response-cleanup

Jul 6, 2020

Collaborator

forslund commented Jul 1, 2020 •

edited

Loading

Description

Adds wait_for_message() method and refactors the common code shared with wait_for_response() into a separate class.

How to test

Make sure integration tests pass and that for example get_response() in skills work. and the :skills cli command

Contributor license agreement signed?

CLA [ Yes ]

forslund added the Type: Refactoring and other improvements label

devops-mycroft added the CLA: Yes label

devops-mycroft commented Jul 2, 2020

Voight Kampff Integration Test Failed (Results)

MycroftAI deleted a comment from devops-mycroft

MycroftAI deleted a comment from devops-mycroft

devops-mycroft commented Jul 2, 2020

Voight Kampff Integration Test Failed (Results)

forslund force-pushed the feature/wait-for-response-cleanup branch from c33c151 to 63d8879 Compare

July 3, 2020 06:32

forslund changed the title ~~Clean up the wait_for_response method~~ Add wait_for_message method

forslund force-pushed the feature/wait-for-response-cleanup branch from 63d8879 to 4707ffc Compare

July 3, 2020 06:48

devops-mycroft commented Jul 3, 2020

Voight Kampff Integration Test Failed (Results)

devops-mycroft commented Jul 3, 2020

Voight Kampff Integration Test Succeeded (Results)

forslund force-pushed the feature/wait-for-response-cleanup branch from 4707ffc to 9a71c61 Compare

July 3, 2020 09:57

devops-mycroft commented Jul 3, 2020

Voight Kampff Integration Test Succeeded (Results)

forslund force-pushed the feature/wait-for-response-cleanup branch from 9a71c61 to 511b554 Compare

July 3, 2020 10:55

devops-mycroft commented Jul 3, 2020

Voight Kampff Integration Test Failed (Results)

2 similar comments

devops-mycroft commented Jul 3, 2020

Voight Kampff Integration Test Failed (Results)

devops-mycroft commented Jul 4, 2020

Voight Kampff Integration Test Failed (Results)

forslund added 3 commits

July 5, 2020 09:28


          Clean up the wait_for_response method

29f60e6

- Use nonlocal instead of mutable object.
- Set default timeout in method argument


          Add wait_for_message() method to messagebus client

b7d709c

- Refactor message waiting into a MessageWaiter class to be able to use the
  same code in both wait_for_message and wait_for_response.
- Add some basic unittests


          Use bus.wait_for_message() method to wait for speak

2bb9783

forslund force-pushed the feature/wait-for-response-cleanup branch from 511b554 to 2bb9783 Compare

July 5, 2020 14:40

devops-mycroft commented Jul 5, 2020

Voight Kampff Integration Test Failed (Results)

devops-mycroft commented Jul 5, 2020

Voight Kampff Integration Test Succeeded (Results)

Contributor

krisgesling commented Jul 6, 2020

Nice one, love the ability to separate construction from executing the wait.

Merging.

krisgesling merged commit f6dba98 into MycroftAI:dev

Contributor

JarbasAl commented Jul 6, 2020 •

edited

Loading

when documenting this we should make a note objects can not be reused, since we use self.bus.once we need to create a new object for every call

i dont think refactoring to allow this makes sense either, just ensure its documented to avoid head scratches

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA: Yes Type: Refactoring and other improvements