This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Do not call max if files list is empty #2662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devops-mycroft
added
the
CLA: Yes
forslund
reviewed
Aug 14, 2020
krisgesling
force-pushed
the
bugfix/empty-arg
branch
from
7796958
to
8065f5c
Compare
|
Voight Kampff Integration Test Succeeded (Results) |
forslund
approved these changes
Aug 14, 2020
|
Voight Kampff Integration Test Succeeded (Results) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Method that checks modified date of files attempts to call
max()even if the list of files is empty. Results in:This change checks if the list is populated first.
How to test
Run dev branch on a Mark 1, after booting uninstall a Skill.
Contributor license agreement signed?