This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Remove deprecated EventEmitter classes #2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisgesling
added
the
Status: Work in progress
devs-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Succeeded (Results) |
krisgesling
removed
the
Status: Work in progress
forslund
approved these changes
Aug 18, 2020
|
Maybe add a 20.08 tag on these PR's removing deprecated method / classes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes deprecated
pyee.EventEmitterclasses and the homespunThreadedEventEmitter.Most instances can inherit from the
pyee.BaseEventEmitterclass. Those using theThreadedEventEmitterhave been switched to thepyee.ExecutorEventEmitter.A small update was also made to the event scheduling test to account for the lack of wrappers.
How to test
Run unit and integration tests
Contributor license agreement signed?