Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Remove unnecessary string utils #2672

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Remove unnecessary string utils #2672

merged 2 commits into from
Aug 21, 2020

Conversation

krisgesling
Copy link
Contributor

Description

Removes the get_http and remove_last_slash functions from string utils. These were previously used to massage uri's but should no longer be required.

How to test

Play news stations using https

Contributor license agreement signed?

@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Aug 18, 2020
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

Copy link
Collaborator

@forslund forslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, to note is that the default play_mp3 and play_ogg will not work with https. Which is OK because the https->http transform may or may not have worked at all before.

@krisgesling krisgesling merged commit a3a869b into dev Aug 21, 2020
@krisgesling krisgesling deleted the remove/string-utils branch September 2, 2020 21:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants