This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Fix vlc audioservice loading #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The basic name caused collisions between the "vlc" audioservice and the vlc module. This prepends an "audioservice_" to the service folder name.
devops-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Succeeded (Results) |
krisgesling
added
Merge after next release
|
Smart move and works great, thanks for getting it fixed up :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set a more specific module name for audioservices
The basic name caused collisions between the "vlc" audioservice and the
vlc module. This prepends an "audioservice_" to the service folder name. vlc would not load with the error message
How to test
Check that the vlc audioservice is properly loaded.
Contributor license agreement signed?
CLA [ Yes ]