Issue-2567 - Fixing not initialized dialog_render #2685
Conversation
devops-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Failed (Results) |
|
Voight Kampff Integration Test Succeeded (Results) |
|
Hi Katridi, thanks for taking a look at this and submitting a fix. I see you've added a test to |
|
No, you're right. I've put it in a wrong place. Thanks for pointing out! |
|
Voight Kampff Integration Test Succeeded (Results) |
1 similar comment
|
Voight Kampff Integration Test Succeeded (Results) |
|
Am working on the Travis CI issue too, it has built successfully but seems to be an issue in reporting this. |
|
Voight Kampff Integration Test Succeeded (Results) |
| @@ -602,6 +602,13 @@ def test_translate_locations(self): | |||
| # Restore lang to en-us | |||
| s.config_core['lang'] = 'en-us' | |||
|
|
|||
| def test_speak_dialog_render_not_intialized(self): | |||
| @@ -602,6 +602,13 @@ def test_translate_locations(self): | |||
| # Restore lang to en-us | |||
| s.config_core['lang'] = 'en-us' | |||
|
|
|||
| def test_speak_dialog_render_not_intialized(self): | |||
| """Test that non-initialzed dialog_renderer won't raise an error.""" | |||
There was a problem hiding this comment.
Different typo on initialized
|
Voight Kampff Integration Test Succeeded (Results) |
1 similar comment
|
Voight Kampff Integration Test Succeeded (Results) |
Description
Fix for issue #2567
How to test
Run
test/unittests/skills/test_mycroft_skill.pyto ensure thattest_speak_dialog_render_not_intializedwon't failContributor license agreement signed?
CLA [ ] (Whether you have signed a CLA - Contributor Licensing Agreement