Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Bugfix/duration stretch update #2691

Merged
merged 3 commits into from
Sep 25, 2020

Conversation

forslund
Copy link
Collaborator

Description

Chat user hniazi discovered that the duration_stretch setting wasn't updated as expected when configuration was updated. It turned out the method looked a global scoped config and not the object specific config. This fixes that issue.

It also changes the global variable names to uppercase to make this kind of issue harder happen again.

How to test

Add a tts section to your user's config file

"tts": {
  "module": "mimic",
  "mimic": {"duration_stretch": "1.3"}
}

then trigger a config reload
python -m mycroft.messagebus.send "configuration.updated"
Make mycroft talk to hear the slower speech

Change the value to something like "0.5" trigger an update again and make sure mycroft now talks really fast.

Contributor license agreement signed?

CLA [ Yes ]

@devops-mycroft devops-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Sep 12, 2020
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@forslund
Copy link
Collaborator Author

What does the complex tag mean?

@krisgesling
Copy link
Contributor

Mild judgement call, but anything not straightforward.
Eg things that touch multiple areas of the codebase, might have side effects, or require someone with specific knowledge of a system to review.

Having a quick look at the changes I believe I got this one wrong :)

Copy link
Contributor

@krisgesling krisgesling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, and it helped me catch one of those nebulous pyee errors 🎉

I also remembered that I converted the old "bug" label to this one which is why it got tagged "complex".

@krisgesling krisgesling merged commit 1c80eab into MycroftAI:dev Sep 25, 2020
@forslund forslund deleted the bugfix/duration_stretch-update branch September 25, 2020 06:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) Status: To be reviewed Concept accepted and PR has sufficient information for full review Type: Bug - complex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants