This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Mimic arm fix #2716
Merged
Mimic arm fix #2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devops-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Failed (Results) |
|
Seems like this PR contains #2715 as well |
|
Fixed, neglected to rebase |
|
Voight Kampff Integration Test Succeeded (Results) |
|
Tested this on both arm devices and my desktop and it looks quite correct. Are you ok with me rebasing and dropping the extra commits before merging? |
|
Works for me. |
|
Voight Kampff Integration Test Succeeded (Results) |
forslund
approved these changes
Oct 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the memory calculation to reduce the number of cores, particularly on low-memory hosts (ie, pi3/4 with <8gb).
How to test
Run dev_setup.sh on a host with a low amount of memory, observe it saying "Building with 1 cores..." (1 or relevant number for your system).
4gb or less should have 1. 8gb, 3. 12gb, 5. 16gb, 7.
Contributor license agreement signed?
CLA [X]