This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
allow variants of arch (archarm, ...) to fetch dependencies (dev_setup.sh) #2725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devops-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Failed (Results) |
|
Looks like good changes, thanks. Gonna ask briefly on the chat if an arch / manjaro user can test it. |
|
Voight Kampff Integration Test Succeeded (Results) |
|
@ChanceNCounter tested it with Manjaro and is working as expected. |
forslund
approved these changes
Oct 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Arch Linux Arm doesn't fetch dependencies in the installation process
Just added
&& ( ... || os_is_like arch)to let variants like archarm pass the filtersince os-release (archarm)
Alternatively this could be handled with
os_is archarm, yet i've seen many (core) arch variants which could run into the same problem. This should also pass Manjaro, i guess.