-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add Plugin base classes APIs to readthedocs #2736
Conversation
Voight Kampff Integration Test Succeeded (Results) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Ake, this is such a huge improvement, thankyou!!!
A bunch of comments but all little things. Definitely push back if I've misunderstood anything.
e7a08a9
to
3a0e039
Compare
I've updated with the suggested texts (in all cases except one) I tried to reword the index page. but might need some more tlc. |
Voight Kampff Integration Test Failed (Results) |
Voight Kampff Integration Test Succeeded (Results) |
Is there a commit missing here, I'm seeing a few unchanged. Also small nitpick - we don't seem to be consistent with the argument type being before or after the colon, eg:
|
I'll look over the argument type changes. Likely I've gotten confused over time and mix up the order. Can you give an example of unchanged? |
3a0e039
to
e552910
Compare
Now I see what you mean. I seem to have missed most of your comments. sorry about that |
Voight Kampff Integration Test Succeeded (Results) |
I think this is once more ready for review. All of the comments should be handled now...I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic!
Thanks!
Description
This updates the docstrings for the base classes for the pluggable systems to provide more of the information needed for creating plugins. Plugins are also added to the API documentation.
I'd very much appreciate improvementson the docstrings I've suggested here.
How to test
run
make html
in thedocs
folder and check that the resulting plugin documentation looks good.Contributor license agreement signed?
CLA [ Yes ]