Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Only build mimic once during travis tests #2745

Merged
merged 2 commits into from
Nov 4, 2020

Conversation

forslund
Copy link
Collaborator

Description

Save some CPU cycles by only building mimic once. The build shouldn't
differ vastly (or at all) between runs.

How to test

Check that only Python 3.9 builds mimic as part of the Travis tests.

Contributor license agreement signed?

CLA [ Yes ]

Save some CPU cycles by only building mimic once. The build shouldn't
differ vastly (or at all) between runs.
@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Oct 29, 2020
@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results)

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@krisgesling krisgesling added the Type: Tests Addition or improvement of automated tests label Oct 30, 2020
Copy link
Contributor

@krisgesling krisgesling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah makes sense, there shouldn't be any difference between the builds. Nice one!

I just extended the comment slightly to make it clearer why we're skipping the builds

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@forslund forslund merged commit 6802694 into MycroftAI:dev Nov 4, 2020
@forslund forslund deleted the test/travis-build-mimic-once branch November 4, 2020 20:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) Type: Tests Addition or improvement of automated tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants