Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Fix UnboundLocalError in AudioProducer #2780

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

dalgwen
Copy link

@dalgwen dalgwen commented Dec 15, 2020

==== Fixed Issues ====
#2779

==== Tech Notes ====
The variable should be declared outside the loop.

Description

fixes an UnboundLocalError exception

How to test

Basic use of mycroft. Nothing broken, then good to go.

Contributor license agreement signed?

CLA [X]

==== Fixed Issues ====

====  Tech Notes ====
The variable should be declared outside the loop.
@devops-mycroft devops-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Dec 15, 2020
@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results)

Copy link
Collaborator

@forslund forslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, Looks good!

@krisgesling krisgesling added Status: Accepted PR has been reviewed and accepted. There must be some reason why it isn't being merged. Type: Bug - quick Bug fixes that are quick to review and the implications of the change are clear and contained. labels Dec 15, 2020
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@krisgesling
Copy link
Contributor

Awesome thanks @dalgwen!

@krisgesling krisgesling merged commit 4c254aa into MycroftAI:dev Dec 15, 2020
@dalgwen dalgwen deleted the bugfix/issue-2779 branch January 12, 2021 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) Status: Accepted PR has been reviewed and accepted. There must be some reason why it isn't being merged. Type: Bug - quick Bug fixes that are quick to review and the implications of the change are clear and contained.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants