This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Remove six from dependencies #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although some of the dependencies of MyCroft still use it, MyCroft itself seems to have no uses of this anywhere, so let's get rid of it (dependencies will pull it in on their own)
devops-mycroft
added
the
CLA: Yes
forslund
approved these changes
Dec 20, 2020
|
Seems like the Jenkins CI isn't up at the moment (502 error), will wait with the merge until it's back up (I trust the autobots more than myself :) ) |
|
Voight Kampff Integration Test Succeeded (Results) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Although some of the dependencies of MyCroft still use it, MyCroft
itself seems to have no uses of this anywhere, so let's get rid of it
(dependencies will pull it in on their own)
How to test
Run the tests, validate normal functionality as before, run a
grep -r six.Contributor license agreement signed?
CLA [X]