This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Unshadow Message class in _handle_pairing_complete #2790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a small typo making the unmute after first pairing call fail.
devops-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Succeeded (Results) |
krisgesling
approved these changes
Jan 5, 2021
|
This is a good fix for the immediate issue so merging it in. It does make me question if there is a reason this unmute isn't called from the Pairing Skill itself? |
|
I think the original reason that it was put in the enclosure was that it would depend on the platform whether it was needed to mute / unmute the mic during initial setup. |
|
Indeed, mute at that part wasn't working. The Hey Mycroft demo sentences at the end triggered the device. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue spotted by @j1nx, the "Message" class is shadowed by the unused "Message" argument.
Pairing (previously at least) muted the mic until pairing was complete. The restoration of the mic state has been broken (it seems) since the Mark-2 work began. Which leads me to believe that the initial mute of the mic isn't working.
This will not make things work worse and the code will do what it tries to do but if the mute during pairing is something we don't want in the future we should just remove this handler.
Contributor license agreement signed?
CLA [ Yes ]