Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

bug/vlc --no-video #2791

Merged
merged 1 commit into from
Jan 5, 2021
Merged

bug/vlc --no-video #2791

merged 1 commit into from
Jan 5, 2021

Conversation

JarbasAl
Copy link
Contributor

@JarbasAl JarbasAl commented Jan 4, 2021 •
edited
Loading

adds the --no-video flag to vlc audio backend

when playing youtube live streams it opens a vlc window on desktop, it also crashes the audio service if i close it

test with https://github.com/JarbasSkills/skill-old-world-radio

@devops-mycroft devops-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Jan 4, 2021
@JarbasAl JarbasAl requested a review from forslund January 4, 2021 22:38
@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

forslund
forslund approved these changes Jan 5, 2021
View reviewed changes
Copy link
Collaborator

@forslund forslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I have a prepared branch with exactly this laying around :) Approved!

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@forslund forslund merged commit 33ee6c1 into MycroftAI:dev Jan 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@forslund forslund forslund approved these changes

Assignees
No one assigned
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JarbasAl @devops-mycroft @forslund