Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Bug Fix - Use the correct delegate, fix layouts, autofit text for System TextFrame #2815

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

AIIX
Copy link
Collaborator

@AIIX AIIX commented Jan 21, 2021

Description

Switch the text frame to use the correct delegate, fixes layout and autofit text should scale properly with word wrapping

How to test

self.gui.show_text("some very long text / paragraph") and the text should be scaling properly

Contributor license agreement signed?

CLA [x] (Whether you have signed a CLA - Contributor Licensing Agreement

@devops-mycroft devops-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Jan 21, 2021
@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

@krisgesling krisgesling added Status: To be reviewed Concept accepted and PR has sufficient information for full review Type: Bug - quick Bug fixes that are quick to review and the implications of the change are clear and contained. labels Jan 22, 2021
Copy link
Collaborator

@forslund forslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and the auto scaling of the text works really well!

@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

@krisgesling krisgesling merged commit 8e51083 into MycroftAI:dev Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) Status: To be reviewed Concept accepted and PR has sufficient information for full review Type: Bug - quick Bug fixes that are quick to review and the implications of the change are clear and contained.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants