This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
add skill_id to converse error msg #2827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisgesling
added
the
Type: Enhancement - proposed
devops-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Failed (Results). |
forslund
approved these changes
Feb 8, 2021
|
Voight Kampff Integration Test Failed (Results). |
|
Voight Kampff Integration Test Succeeded (Results) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Was seeing the converse error in a log file a lot but the error message doesn't give you the context of which Skill is throwing it. Hence it takes extra digging to work this out.
This adds the skill_id to the error message
How to test
Apply this change to mycroft-core v20.8.0 and run the VK tests on the latest mycroft-timer Skill.
The Skill will fail due to calling a method that doesn't yet exist.
The more complete error message will be displayed:
Contributor license agreement signed?