This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Use os default gcc in github workflow #2830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devops-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Succeeded (Results) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GCC 4.8 seems to have been removed from ubuntu latest used by the github workflow. This drops the explicit use of the older version in favor for the default.
GCC 4.8 was previously hardcoded to make mimic build slightly faster. Either newer gcc has improved over gcc 6.x or gitlab has more horse powers but this seems to run just fine.
How to test
Ensure that the unittests run by github passes for python 3.9 (which builds mimic)
Contributor license agreement signed?
CLA [ Yes ]