-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
Voight Kampff Integration Test Succeeded (Results) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this will not automatically update 2.2.2 to 2.2.3 if a new release is pushed upstream.
Looks like the gtts language list has been updated so |
Thanks for pointing out the deprecated lang codes. I've also removed these from the cached list of supported languages, and switched all references to the two-character "en". And yeah, the relaxed requirement definition won't automatically update the package but figured it would at least work for new installs. Still need to setup the automated testing on all these so we can proactively and confidently update rather than wait for things to break. |
Voight Kampff Integration Test Failed (Results). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good,
gtts.tts_langs()
returns zh-CN and zh-TW (captal letters) in addition to the updated set, reading the code they look active but I might be wrong.
Voight Kampff Integration Test Succeeded (Results) |
Description
Restore Google voice functionality with updated Python package.
Fixes #2825
Thanks to @goldyfruit for diagnosing and testing the updated package.
How to test
Switch voice to Google and see if it works against gTTS 2.2.0 vs 2.2.2
Contributor license agreement signed?