Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Upgrade gTTS to fix Google voice #2831

Merged
merged 2 commits into from
Feb 10, 2021
Merged

Upgrade gTTS to fix Google voice #2831

merged 2 commits into from
Feb 10, 2021

Conversation

krisgesling
Copy link
Contributor

Description

Restore Google voice functionality with updated Python package.

Fixes #2825

Thanks to @goldyfruit for diagnosing and testing the updated package.

How to test

Switch voice to Google and see if it works against gTTS 2.2.0 vs 2.2.2

Contributor license agreement signed?

  • CLA

@krisgesling krisgesling added Status: To be reviewed Concept accepted and PR has sufficient information for full review Type: Bug - quick Bug fixes that are quick to review and the implications of the change are clear and contained. labels Feb 9, 2021
@devops-mycroft devops-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Feb 9, 2021
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

forslund
forslund previously approved these changes Feb 9, 2021
Copy link
Collaborator

@forslund forslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this will not automatically update 2.2.2 to 2.2.3 if a new release is pushed upstream.

@forslund
Copy link
Collaborator

forslund commented Feb 9, 2021

Looks like the gtts language list has been updated so en-us is just en and the test case needs to be updated attest_google_tts.py:L17

@krisgesling
Copy link
Contributor Author

Thanks for pointing out the deprecated lang codes. I've also removed these from the cached list of supported languages, and switched all references to the two-character "en".

And yeah, the relaxed requirement definition won't automatically update the package but figured it would at least work for new installs. Still need to setup the automated testing on all these so we can proactively and confidently update rather than wait for things to break.

@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

Copy link
Collaborator

@forslund forslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,

gtts.tts_langs() returns zh-CN and zh-TW (captal letters) in addition to the updated set, reading the code they look active but I might be wrong.

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@krisgesling krisgesling merged commit fa5576a into dev Feb 10, 2021
@krisgesling krisgesling deleted the bugfix/google-voice branch February 10, 2021 01:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) Status: To be reviewed Concept accepted and PR has sufficient information for full review Type: Bug - quick Bug fixes that are quick to review and the implications of the change are clear and contained.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gTTS needs to be upgraded to 2.2.2 on dev branch
3 participants