Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Remove example entries in blacklisted_skills config #2844

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

krisgesling
Copy link
Contributor

@krisgesling krisgesling commented Feb 22, 2021

The default mycroft.conf included a short list of Skills in the blacklisted_skills configuration. This was put in place when Skills were moved and renamed to prevent two versions of the Skill being loaded.

If a user now attempted to use a Skill that matched one of these names, it would be prevented from loading. This removes the old Skill names from the config.

How to test

Clone the pianobar-skill rather than installing via MSM.

  • On all current releases, this will be blacklisted.

Contributor license agreement signed?

The default mycroft.conf included some arbitrary examples in the
actual blacklisted_skills configuration. If a user attempted to
use a Skill that matched, it would be prevented from loading.
@krisgesling krisgesling added the Type: Bug - quick Bug fixes that are quick to review and the implications of the change are clear and contained. label Feb 22, 2021
@devops-mycroft devops-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Feb 22, 2021
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@forslund
Copy link
Collaborator

They weren't examples, but skills that were actually blacklisted. They may still linger on git based installs. but should be ok to remove I think...(should no longer load I think)

@krisgesling
Copy link
Contributor Author

Ah right, I did wonder if there was some reason for them actually being there.

Do you remember why pianobar got blacklisted?

@forslund
Copy link
Collaborator

It was moved from the old user to mycroft-core and renamed. to make sure the skill weren't loaded twice the old name was blacklisted

@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

1 similar comment
@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@krisgesling krisgesling merged commit f54300d into dev Mar 10, 2021
@krisgesling krisgesling deleted the bugfix/fake-blacklist branch March 10, 2021 14:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) Type: Bug - quick Bug fixes that are quick to review and the implications of the change are clear and contained.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants