This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Fix dev_setup.sh max cores detection #2857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define LANGUAGE along with LANG to ensure that free uses english output
forslund
added
the
Type: Bug - quick
devops-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Succeeded (Results) |
krisgesling
approved these changes
Mar 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue with non-english setups calculating number of CPU's to use when building mimic.
Define LANGUAGE along with LANG to ensure that free uses english output.
Alternative solution seems to be to use LANG=C (and dropping the utf-8 part), not sure which is technically better.
How to test
Using non-english locale and ensure the script doesn't report error on line 541 similar to
Contributor license agreement signed?
CLA [ Yes ]