Check for the AVX instruction set during install #2910
Conversation
krisgesling
added
Type: Enhancement - proposed
Fix long line string
krisgesling
force-pushed
the
feature/avx-check
branch
from
c42f07a
to
771b8aa
Compare
devops-mycroft
added
the
CLA: Yes
|
Rebased - please also be sure to squash commits if merging. |
|
Voight Kampff Integration Test Succeeded (Results) |
Codecov Report
@@ Coverage Diff @@
## dev #2910 +/- ##
=======================================
Coverage 52.60% 52.60%
=======================================
Files 123 123
Lines 11000 11007 +7
=======================================
+ Hits 5786 5790 +4
- Misses 5214 5217 +3
Continue to review full report at Codecov.
|
| @@ -174,6 +174,30 @@ This script is designed to make working with Mycroft easy. During this | |||
| first run of dev_setup we will ask you a few questions to help setup | |||
| your environment.' | |||
| sleep 0.5 | |||
| if ! grep -q avx /proc/cpuinfo && [[ ! $(uname -m) == 'arm'* ]]; then | |||
There was a problem hiding this comment.
Forgive me but I am not sure of the objective. I understand the check for avx via cpuinfo but must admit the arm check is confusing me. What is going on here?
There was a problem hiding this comment.
As eltocino replied below, however it is the inevitable question - so I've added a comment to explain for future devs.
The AVX instruction set is an x86 construct. ARM has a range of equivalents, but I'm not sure which are supported or not by TF. So this is intended to catch the bulk of the support issues we get which is from people trying to install Mycroft on older or low-end x86 hardware.
|
@ken-mycroft AVX is an x86 construct, ARM does not have it. |
|
Voight Kampff Integration Test Succeeded (Results) |
Description
Add a check for the AVX instruction set on non-ARM processors during install. If this required instruction set is not found it will warn the user that the Precise Engine will not be supported.
Replaces #2269
Thanks to @mathmauney for the original work on this.
How to test
Run installer on a machine that does not support AVX
or change line 140 so it is searching for something that definitely doesn't exist in the cpuinfo eg change "avx" to "avxzzz"
Contributor license agreement signed?
Yes - both original author and myself.