Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Issues 86 - Add basic welcome skill #87

Merged
merged 6 commits into from
Jun 2, 2016

Conversation

ethanaward
Copy link
Contributor

I added a skill that will have Mycroft say "You're welcome" when you say either "thanks" or "thank you".

@LongBoolean
Copy link

I made a similar skill my self, great minds think alike aye. It may seem like a simple or unimportant type of skill to have, but I do think there are some good things about having a "candid response" skill. (as @clusterfudge once phased it) I think at the moment if you want to nonchalantly refer to mycroft in conversation with out getting "I don't understand your request" you need to put mycroft to sleep. But there are cases where it would be nice to say out loud "Mycroft sure is amazing!" and have a response more like "Thank you for the compliment." Of coarse skills like this don't seem to be a high priority at the moment, but I do think such a skill would help cover up some of the holes and make the mycroft experience feel a little more complete.

@ethanaward
Copy link
Contributor Author

Yeah, it definitely makes Mycroft seem more complete, especially getting more coverage so that he doesn't say "I don't understand your request" to quite so many things. I also did this so that I could get a handle on skill creation with a basic skill, as well as for documentation purposes so that people can see how to create a simple skill.

@ryanleesipes
Copy link

LGTM, merging.

@ryanleesipes ryanleesipes merged commit 3b9fefe into MycroftAI:master Jun 2, 2016
NeonDaniel pushed a commit to NeonDaniel/mycroft-core that referenced this pull request Jun 8, 2022
* deprecate DevicePrimer pairing stuff

* fully deprecate DevicePrimer

authored-by: jarbasai <jarbasai@mailfence.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants