Fix mycroft-gui-core loader and stop #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conditional statement in the stop script was never actually closed Also fix some shellcheck issues while we're at it
|
Nice catch! Should the exit be |
|
Yes, shellcheck mentions it and it's to make sure we exit in case cd'ing fails. E.g. the directory might for whatever reason not exist anymore and otherwise the |
|
Yeah I understand the reason, just thinking that instead of a bare exit (which returns 0 if I recall correctly) it should call with a non-zero code to indicate exit on failure |
|
Ah, yeah I guess so. Will change |
|
Ah it uses the last exit code. I take it all back :) |
|
It's fine as is. I was wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conditional statement in the stop script was never actually closed
Also fix some shellcheck issues while we're at it