Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add converse and stop vocab to match vk specs. note this change also … #108

Closed
wants to merge 3 commits into from

Conversation

ken-mycroft
Copy link

…requires a change to the common play framework

Description

Fixes Jira SKILL-108

Type of PR

If your PR fits more than one category, there is a high chance you should submit more than one PR. Please consider this carefully before opening the PR.
Either delete those that do not apply, or add an x between the square brackets like so: - [x]

  • Bugfix
  • Feature implementation
  • Refactor of code (without functional changes)
  • Documentation improvements
  • Test improvements

Try to stop the news using any word other than stop

ken-mycroft and others added 3 commits May 4, 2021 07:20
…requires a change to the common play framework
Message for converse debugging was logged every time the News Skill was active and an utterance was made. Hence converse wasn't confused, it is working as intended.
@krisgesling
Copy link
Contributor

This is a less complete version of your PR #113 so closing.

@krisgesling krisgesling deleted the fix_no_stop branch August 12, 2021 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants