Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fr-fr dialog and voc files #198

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Conversation

dokime7
Copy link
Contributor

@dokime7 dokime7 commented Jan 5, 2022

Description

Fix and update dialog, voc and intents files for the fr-fr language in order to fix many errors like mycroft-weather.mycroftai KeyError: 'temp'

Type of PR

  • Bugfix
  • Feature implementation
  • Refactor of code (without functional changes)
  • Documentation improvements
  • Test improvements

Testing

No test added, only dialog and voc files has been updated, no code changes.

Documentation

No documentation needed for this.

@dokime7
Copy link
Contributor Author

dokime7 commented Jan 5, 2022

I've just discovered
https://translate.mycroft.ai/fr/mycroft-skills/skill-weather-fr.po
It seems overlapping that...
How are these translations supposed to be integrated and when?

@forslund
Copy link
Collaborator

There is a script to generate PR's from the translations on translate.mycroft.ai. I think @krisgesling is the one who schedules when it is run.

The changes there will overwrite the changes in this PR if it's merged before the (semi-)automated job is run.

@krisgesling
Copy link
Contributor

Hey, thanks for the translation improvements.

The script is having some trouble with this skill and given you've done all the work here I'm going to merge it in.

Just note Ake's warning about changes potentially getting overwritten in the future.

@krisgesling krisgesling merged commit 9acb334 into MycroftAI:21.02 Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants