forked from nodejs/node
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
build: drop Travis in favor of Actions
GitHub Actions is running all tests already present on Travis, as well as building on more platforms (OS X and Windows). With Travis we're also getting timeouts more frequently than with Actions, which gives the false impression tests are failing (making it harder to triage PRs ready to merge). To make our config simpler, CI.yml and pythonpackage.yml got merged. The coverage is also increased by running tests on OS X. Signed-off-by: Matheus Marchini <mmarchini@netflix.com> PR-URL: nodejs#32450 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
- Loading branch information
1 parent
c2e00ed
commit 9d80c47
Showing
10 changed files
with
167 additions
and
212 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
name: build-windows | ||
|
||
on: [push, pull_request] | ||
|
||
env: | ||
PYTHON_VERSION: 3.8 | ||
FLAKY_TESTS: dontcare | ||
|
||
jobs: | ||
build-windows: | ||
runs-on: windows-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Set up Python ${{ env.PYTHON_VERSION }} | ||
uses: actions/setup-python@v1 | ||
with: | ||
PYTHON_VERSION: ${{ env.PYTHON_VERSION }} | ||
- name: Install deps | ||
run: choco install nasm | ||
- name: Environment Information | ||
run: npx envinfo | ||
- name: Build | ||
run: ./vcbuild.bat |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
name: linters | ||
|
||
on: [push, pull_request] | ||
|
||
env: | ||
PYTHON_VERSION: 3.8 | ||
NODE_VERSION: 10.x | ||
|
||
jobs: | ||
lint-addon-docs: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Use Node.js ${{ env.NODE_VERSION }} | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{ env.NODE_VERSION }} | ||
- name: Environment Information | ||
run: npx envinfo | ||
- name: Lint addon docs | ||
run: NODE=$(which node) make lint-addon-docs | ||
lint-cpp: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Set up Python ${{ env.PYTHON_VERSION }} | ||
uses: actions/setup-python@v1 | ||
with: | ||
PYTHON_VERSION: ${{ env.PYTHON_VERSION }} | ||
- name: Environment Information | ||
run: npx envinfo | ||
- name: Lint C/C++ files | ||
run: make lint-cpp | ||
lint-md: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Use Node.js ${{ env.NODE_VERSION }} | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{ env.NODE_VERSION }} | ||
- name: Environment Information | ||
run: npx envinfo | ||
- name: Lint docs | ||
run: | | ||
echo "::add-matcher::.github/workflows/remark-lint-problem-matcher.json" | ||
NODE=$(which node) make lint-md | ||
lint-js: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Use Node.js ${{ env.NODE_VERSION }} | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{ env.NODE_VERSION }} | ||
- name: Environment Information | ||
run: npx envinfo | ||
- name: Lint JavaScript files | ||
run: NODE=$(which node) make lint-js | ||
lint-py: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Set up Python ${{ env.PYTHON_VERSION }} | ||
uses: actions/setup-python@v1 | ||
with: | ||
PYTHON_VERSION: ${{ env.PYTHON_VERSION }} | ||
- name: Environment Information | ||
run: npx envinfo | ||
- name: Lint Python | ||
run: | | ||
make lint-py-build || true | ||
NODE=$(which node) make lint lint-py |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
name: misc | ||
|
||
on: [push, pull_request] | ||
|
||
env: | ||
NODE_VERSION: 12.x | ||
|
||
jobs: | ||
build-docs: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Use Node.js ${{ env.NODE_VERSION }} | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{ env.NODE_VERSION }} | ||
- name: Environment Information | ||
run: npx envinfo | ||
- name: Build | ||
run: NODE=$(which node) make doc-only | ||
- uses: actions/upload-artifact@v1 | ||
with: | ||
name: docs | ||
path: out/doc |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
name: test-linux | ||
|
||
on: [push, pull_request] | ||
|
||
env: | ||
PYTHON_VERSION: 3.8 | ||
FLAKY_TESTS: dontcare | ||
|
||
jobs: | ||
test-linux: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Set up Python ${{ env.PYTHON_VERSION }} | ||
uses: actions/setup-python@v1 | ||
with: | ||
PYTHON_VERSION: ${{ env.PYTHON_VERSION }} | ||
- name: Environment Information | ||
run: npx envinfo | ||
- name: Build | ||
run: make build-ci -j2 V=1 | ||
- name: Test | ||
run: make run-ci -j2 V=1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
name: test-macOS | ||
|
||
on: [push, pull_request] | ||
|
||
env: | ||
PYTHON_VERSION: 3.8 | ||
FLAKY_TESTS: dontcare | ||
|
||
jobs: | ||
test-macOS: | ||
runs-on: macos-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Set up Python ${{ env.PYTHON_VERSION }} | ||
uses: actions/setup-python@v1 | ||
with: | ||
PYTHON_VERSION: ${{ env.PYTHON_VERSION }} | ||
- name: Environment Information | ||
run: npx envinfo | ||
- name: Build | ||
run: make build-ci -j8 V=1 | ||
- name: Test | ||
run: make run-ci -j8 V=1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,7 +19,6 @@ | |
!.gitkeep | ||
!.mailmap | ||
!.nycrc | ||
!.travis.yml | ||
!.eslintrc.yaml | ||
!.cpplint | ||
|
||
|
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.