Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change vscode extension name #1097

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

Freed-Wu
Copy link
Contributor

@Freed-Wu Freed-Wu commented Jan 1, 2025

Avoid:
Error: Duplicate workspace name tinymist: /the/path/of/tinymist/editors/vscode conflicts with /the/path/of/tinymist

Avoid:
  Error: Duplicate workspace name tinymist: /the/path/of/tinymist/editors/vscode conflicts with /the/path/of/tinymist
@Myriad-Dreamin
Copy link
Owner

Will this affect publish of vscode extension?

@Freed-Wu
Copy link
Contributor Author

Freed-Wu commented Jan 1, 2025

Or rename https://github.com/Myriad-Dreamin/tinymist/blob/main/package.json#L2
it will avoid rename the vscode extension.

@Myriad-Dreamin Myriad-Dreamin merged commit 2464c5b into Myriad-Dreamin:main Jan 2, 2025
@Myriad-Dreamin
Copy link
Owner

I did rename it back, as the the package identifier depends on the "name" field in the package.json. https://github.com/Myriad-Dreamin/tinymist/pull/1102/files#diff-f88dc1d2e4ebb37a991307d443433a9f8c29bb4c12ba9ab1f00ac4869ad42355R2

@Freed-Wu
Copy link
Contributor Author

Freed-Wu commented Jan 3, 2025

Rename https://github.com/Myriad-Dreamin/tinymist/blob/main/package.json#L2C1-L2C7 is also OK 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants