Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refine label types to remove hacking citation filter #603

Merged
merged 5 commits into from
Sep 20, 2024
Merged

fix: refine label types to remove hacking citation filter #603

merged 5 commits into from
Sep 20, 2024

Conversation

Myriad-Dreamin
Copy link
Owner

The code here is not sound:

let citation = !at && self.before_window(15).contains("cite");

To remove it, we add and identify two more refined label types: cite-label and ref-label.

@Myriad-Dreamin Myriad-Dreamin linked an issue Sep 20, 2024 that may be closed by this pull request
Label autofill pop-up list missing while typing arguments in some user-defined functions #579
Closed
@Myriad-Dreamin Myriad-Dreamin merged commit 6ce6bb8 into main Sep 20, 2024
12 checks passed
@Myriad-Dreamin Myriad-Dreamin mentioned this pull request Sep 20, 2024
Merged
ParaN3xus pushed a commit to ParaN3xus/tinymist that referenced this pull request Sep 23, 2024
@Myriad-Dreamin @ParaN3xus
fix: refine label types to remove hacking citation filter (Myriad-Dre…
0dfe91f 
…amin#603)

* test: check types

* test: confirm bug

* fix: refine label types

* dev: update snapshot

* dev: update snapshot
@BrewTestBot BrewTestBot mentioned this pull request Sep 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Label autofill pop-up list missing while typing arguments in some user-defined functions
1 participant
@Myriad-Dreamin