-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: target to use for cross build and bump version to 0.12.4-rc3 #885
Conversation
platform: linux | ||
arch: arm64 | ||
cross: true | ||
- os: ubuntu-20.04 | ||
rust-target: arm-unknown-linux-gnueabihf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure about this. i dont know the difference between arm targets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We ran into some errors in #884. After diff typst CI scripting with ours, I guessed we should change targets supported by cross.
- os: ubuntu-20.04 | ||
rust-target: x86_64-unknown-linux-gnu | ||
rust-target: x86_64-unknown-linux-musl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can help with rhel. but i heard that some libc function in musl is inefficient. we can observe if there is any slow down after changing this.
Besides installing the musl toolchain, testing the - name: Test tinymist
run: |
- cargo test --profile=gh-release --workspace --target ${{ matrix.rust-target }}
+ cross test --profile=gh-release --workspace --target ${{ matrix.rust-target }} Maybe we can just use |
d2a2358
to
7d9ba63
Compare
Seems that cross-testing |
Seems that |
@Coekjan I've run
Pretty same. Now they built the same target. The only difference is in that build alpine is built in an alpine image. I suspect whether we can remove it right now, but I would rather not touching them until release 0.12.4. |
I'll close it and leave this issue for next release. |
No description provided.