Fixed a bug which calculated the row height based on the last item in…

…stead of the tallest
Myrronth · Mar 12, 2018 · f9b0ce8 · f9b0ce8
1 parent f256b58
commit f9b0ce8
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 4 deletions.
diff --git a/Symbol and Artboard Organizer.sketchplugin/Contents/Sketch/manifest.json b/Symbol and Artboard Organizer.sketchplugin/Contents/Sketch/manifest.json
@@ -4,7 +4,7 @@
   "author": "Tobias Kreß",
   "email": "kress@pixelflut.net",
   "homepage": "https://github.com/Myrronth/symbol-and-artboard-organizer",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "identifier": "net.pixelflut.sketch.symbol-and-artboard-organizerl",
   "appcast": "https://github.com/Myrronth/symbol-and-artboard-organizer/appcast.xml",
   "compatibleVersion": "47",

diff --git a/Symbol and Artboard Organizer.sketchplugin/Contents/Sketch/run.cocoascript b/Symbol and Artboard Organizer.sketchplugin/Contents/Sketch/run.cocoascript
@@ -11,7 +11,7 @@ var onRun = function(context) {
     var verticalGap = 100;
     var symbolArtboardGap = 500;
 
-    var x, y, lastArtboardProxy, lastSymbolProxy;
+    var x, y, maxHeight, lastArtboardProxy, lastSymbolProxy;
 
     artboards.forEach(function(artboard) {
         if(artboard.class() == 'MSArtboardGroup') {
@@ -54,10 +54,10 @@ var onRun = function(context) {
 
     x = 0;
     y = 0;
+    maxHeight = 0;
     lastSymbolProxy = null;
 
     var maxWidth = 0;
-    var maxHeight = 0;
 
     symbolProxies.forEach(function(symbolProxy) {
         var symbol = symbolProxy.symbol;
@@ -118,6 +118,7 @@ var onRun = function(context) {
 
     x = 0;
     y = 0;
+    maxHeight = 0;
     lastArtboardProxy = null;
 
     artboardProxies.forEach(function(artboardProxy) {
@@ -127,7 +128,9 @@ var onRun = function(context) {
         if(lastArtboardProxy) {
             if(lastArtboardProxy.scope != scope && lastArtboardProxy.artboard.name() != scope) {
                 x = 0;
-                y += lastArtboardProxy.artboard.frame().height() + verticalGap;
+                y += maxHeight + verticalGap;
+
+                maxHeight = 0;
             } else {
                 x += lastArtboardProxy.artboard.frame().width() + horizontalGap;
                 y = lastArtboardProxy.artboard.frame().y();
@@ -139,6 +142,7 @@ var onRun = function(context) {
 
         artboard.frame().setOrigin({x, y});
 
+        maxHeight = Math.max(maxHeight, artboardProxy.artboard.frame().height());
         lastArtboardProxy = artboardProxy;
     });
 

diff --git a/appcast.xml b/appcast.xml
@@ -27,5 +27,16 @@
         </description>
         <enclosure url="https://github.com/Myrronth/symbol-and-artboard-organizer/archive/1.0.1.zip" sparkle:version="1.0.1" />
       </item>
+      <item>
+        <title>Version 1.0.2</title>
+        <description>
+          <![CDATA[
+            <ul>
+              <li>Fixed a bug which calculated the row height based on the last item instead of the tallest</li>
+            </ul>
+          ]]>
+        </description>
+        <enclosure url="https://github.com/Myrronth/symbol-and-artboard-organizer/archive/1.0.2.zip" sparkle:version="1.0.2" />
+      </item>
   </channel>
 </rss>