Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error messages #244

Closed
jonas-lj opened this issue Nov 22, 2022 · 2 comments
Closed

Better error messages #244

jonas-lj opened this issue Nov 22, 2022 · 2 comments
Assignees
Labels
fixit_02_2023 FixIt 02/2023

Comments

@jonas-lj
Copy link
Contributor

The error types in FastCryptoError does not currently give a lot of information about what caused them, and while this opaqueness is to some degree intended, we should add a bit more clarity to them. This could be done either by adding more error types or by adding messages to the errors or a combination.

@kchalkias review of #243 gives a few suggestions on what we should change.

@jonas-lj jonas-lj self-assigned this Nov 22, 2022
@benr-ml
Copy link
Contributor

benr-ml commented Nov 22, 2022

+1 for error messages.

Different error types are needed when we believe that the caller would use them differently, but I doubt that anyone would handle differently errors like InvalidInputs vs InputTooShort. General error types like InvalidInputs, OsResourceError, etc should suffice.

Adding an optional error string to errors makes sense for logging purposes.

@benr-ml benr-ml added the fixit_02_2023 FixIt 02/2023 label Feb 6, 2023
@benr-ml
Copy link
Contributor

benr-ml commented Feb 8, 2023

Closed in #410

@benr-ml benr-ml closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixit_02_2023 FixIt 02/2023
Projects
None yet
Development

No branches or pull requests

2 participants