Use FastCryptoError for batched verification #243
Conversation
|
The changes to BLS12381 seem very large, but it's a result of cargo fmt changing the indention after I removed a long string. It might be related to this. But I've only changed the error type in the two methods. |
jonas-lj
requested review from
huitseeker,
kchalkias,
joyqvq and
benr-ml
as code owners
| if sigs.is_empty() { | ||
| return Err(eyre!("Critical Error! This behaviour can signal something dangerous, and that someone may be trying to bypass signature verification through providing empty batches.")); | ||
| return Err(FastCryptoError::InvalidInput); |
There was a problem hiding this comment.
I'd create a new Error type for empty invalid Inputs (or better instantiate this error with a message)
| @@ -160,7 +155,7 @@ impl VerifyingKey for Ed25519PublicKey { | |||
| } | |||
| batch | |||
| .verify(OsRng) | |||
| .map_err(|_| eyre!("Signature verification failed")) | |||
| .map_err(|_| FastCryptoError::GeneralError) | |||
There was a problem hiding this comment.
GeneralError is very broad, let's create SigVerificationError or GeneralError should be instantiated with a message)
| if sigs.is_empty() { | ||
| return Err(eyre!("Critical Error! This behaviour can signal something dangerous, and that someone may be trying to bypass signature verification through providing empty batches.")); | ||
| return Err(FastCryptoError::InvalidInput); |
| } | ||
| if pks.len() != sigs.len() { | ||
| return Err(eyre!("Mismatch between number of signatures and public keys provided")); | ||
| return Err(FastCryptoError::InvalidInput); | ||
| } |
| } | ||
| pks.iter() | ||
| .zip(sigs) | ||
| .try_for_each(|(pk, sig)| pk.verify(msg, sig)) | ||
| .map_err(|_| eyre!("Signature verification failed")) | ||
| .map_err(|_| FastCryptoError::GeneralError) |
Great. I totally agree with your comments regarding the errors. But since it'll require a lot more changes than what I suggest here, I'll postpone it to until after PR #240 is merged where I'll clean up the error handling. I'll add an issue. |
No description provided.