Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fastcrypto: impl bech32 encoding #712
fastcrypto: impl bech32 encoding #712
Changes from all commits
f94808c
42de4b5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
encode receives hrp as an input, why not return it here as an output and let the caller verify consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i went back and forth on this, https://github.com/MystenLabs/sui/pull/15415/files#diff-ccd99b30fee16b246ae935ee7b8c4d336530cc6962dcd611695d73f9493e8876R223 here is the usage in sui
Check warning on line 285 in fastcrypto/src/encoding.rs
Codecov / codecov/patch
fastcrypto/src/encoding.rs#L285
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it uses AsRef, data can be a ref.
(in general we should reduce dependency on AsRef for fastcrypt types, and move to non ref byte arrays / serialized objects, but we can do that later)