Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the default class group hash parameters #819

Merged
merged 15 commits into from
Sep 13, 2024
Merged

Update the default class group hash parameters #819

merged 15 commits into from
Sep 13, 2024

Conversation

jonas-lj
Copy link
Contributor

@jonas-lj jonas-lj commented Aug 7, 2024 •
edited
Loading

  • Update the default parameters for the class group hash to both keeping it fast + ensure security.
  • Update test vectors accordingly.
  • Small updates to the code, mainly for readbility.

The test vectors in sui-framework must be updated after this is merged.

@jonas-lj jonas-lj marked this pull request as ready for review August 7, 2024 13:32
@jonas-lj jonas-lj requested a review from kchalkias August 7, 2024 13:33
kchalkias
kchalkias reviewed Aug 8, 2024
View reviewed changes
fastcrypto-vdf/benches/class_group.rs Show resolved Hide resolved
fastcrypto-vdf/benches/class_group.rs Outdated Show resolved Hide resolved
fastcrypto-vdf/src/class_group/hash.rs Outdated Show resolved Hide resolved
fastcrypto-vdf/src/class_group/hash.rs Outdated Show resolved Hide resolved
fastcrypto-vdf/src/class_group/hash.rs Outdated Show resolved Hide resolved
fastcrypto-vdf/src/class_group/hash.rs Show resolved Hide resolved
@jonas-lj jonas-lj requested a review from kchalkias August 8, 2024 10:55
@jonas-lj jonas-lj force-pushed the jonas/class_group_hash branch from 4389db0 to 0db7492 Compare September 11, 2024 09:22
@jonas-lj jonas-lj merged commit ba4d3e7 into main Sep 13, 2024
7 checks passed
@jonas-lj jonas-lj deleted the jonas/class_group_hash branch September 13, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kchalkias kchalkias kchalkias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonas-lj @kchalkias