[StateAccumulatorV2] Fix edge case; Disable for mainnet #18131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
mystenmark
approved these changes
Jun 7, 2024
williampsmith
force-pushed
the
william/accumulator-v2-fix
branch
from
8c70df7
to
1d51e98
Compare
williampsmith
force-pushed
the
william/accumulator-v2-fix
branch
from
1d51e98
to
5b66cca
Compare
7 tasks
williampsmith
changed the title
williampsmith
force-pushed
the
william/accumulator-v2-fix
branch
from
1d07d7f
to
6f21632
Compare
mwtian
approved these changes
Jun 8, 2024
williampsmith
force-pushed
the
william/accumulator-v2-fix
branch
2 times, most recently
from
26b97cb
to
ed8a9a6
Compare
williampsmith
force-pushed
the
william/accumulator-v2-fix
branch
from
ed8a9a6
to
ebb7f6c
Compare
williampsmith
added a commit
that referenced
this pull request
Jun 8, 2024
## Description If a validator is behind on execution for the entire epoch, then checkpoint builder may craft the final checkpoint of the epoch and attempt to accumulate the root state hash, with the end result being that we skip accumulating all checkpoints of the epoch into the root state hash but the final. This is because to bootstrap running root accumulation at beginning of a new epoch, we use the previous root state hash, and we assume that if there are no running roots for the current epoch, we are handling accumulation for the beginning of the new epoch. To fix, let's check that the previous root state digest is current up to the previous checkpoint, otherwise await ## Test plan The following passes against 100 seeds ``` ./scripts/simtest/seed-search.py simtest --test test_simulated_load_with_reconfig_and_correlated_crashes ``` --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
7 tasks
williampsmith
added a commit
that referenced
this pull request
Jun 8, 2024
## Description If a validator is behind on execution for the entire epoch, then checkpoint builder may craft the final checkpoint of the epoch and attempt to accumulate the root state hash, with the end result being that we skip accumulating all checkpoints of the epoch into the root state hash but the final. This is because to bootstrap running root accumulation at beginning of a new epoch, we use the previous root state hash, and we assume that if there are no running roots for the current epoch, we are handling accumulation for the beginning of the new epoch. To fix, let's check that the previous root state digest is current up to the previous checkpoint, otherwise await ## Test plan The following passes against 100 seeds ``` ./scripts/simtest/seed-search.py simtest --test test_simulated_load_with_reconfig_and_correlated_crashes ``` --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
williampsmith
added a commit
that referenced
this pull request
Jun 8, 2024
## Description If a validator is behind on execution for the entire epoch, then checkpoint builder may craft the final checkpoint of the epoch and attempt to accumulate the root state hash, with the end result being that we skip accumulating all checkpoints of the epoch into the root state hash but the final. This is because to bootstrap running root accumulation at beginning of a new epoch, we use the previous root state hash, and we assume that if there are no running roots for the current epoch, we are handling accumulation for the beginning of the new epoch. To fix, let's check that the previous root state digest is current up to the previous checkpoint, otherwise await ## Test plan The following passes against 100 seeds ``` ./scripts/simtest/seed-search.py simtest --test test_simulated_load_with_reconfig_and_correlated_crashes ``` --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
7 tasks
williampsmith
added a commit
that referenced
this pull request
Jun 8, 2024
## Description CP #18131 ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
tx-tomcat
pushed a commit
to tx-tomcat/sui-network
that referenced
this pull request
Jul 29, 2024
…8131) ## Description If a validator is behind on execution for the entire epoch, then checkpoint builder may craft the final checkpoint of the epoch and attempt to accumulate the root state hash, with the end result being that we skip accumulating all checkpoints of the epoch into the root state hash but the final. This is because to bootstrap running root accumulation at beginning of a new epoch, we use the previous root state hash, and we assume that if there are no running roots for the current epoch, we are handling accumulation for the beginning of the new epoch. To fix, let's check that the previous root state digest is current up to the previous checkpoint, otherwise await ## Test plan The following passes against 100 seeds ``` ./scripts/simtest/seed-search.py simtest --test test_simulated_load_with_reconfig_and_correlated_crashes ``` --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a validator is behind on execution for the entire epoch, then checkpoint builder may craft the final checkpoint of the epoch and attempt to accumulate the root state hash, with the end result being that we skip accumulating all checkpoints of the epoch into the root state hash but the final. This is because to bootstrap running root accumulation at beginning of a new epoch, we use the previous root state hash, and we assume that if there are no running roots for the current epoch, we are handling accumulation for the beginning of the new epoch.
To fix, let's check that the previous root state digest is current up to the previous checkpoint, otherwise await
Test plan
The following passes against 100 seeds
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.