[Consensus] refine logging & small timeout changes #18795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l in choosing consensus protocol.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
mwtian
approved these changes
Jul 25, 2024
| @@ -121,7 +121,7 @@ impl CommitObserver { | |||
| .scan_commits(((last_processed_commit_index + 1)..=CommitIndex::MAX).into()) | |||
| .expect("Scanning commits should not fail"); | |||
|
|
|||
| debug!("Recovering commit observer after index {last_processed_commit_index} with last commit {:?} and {} unsent commits", last_commit, unsent_commits.len()); | |||
| info!("Recovering commit observer after index {last_processed_commit_index} with last commit {:?} and {} unsent commits", last_commit, unsent_commits.len()); | |||
There was a problem hiding this comment.
Suggested change
| info!("Recovering commit observer after index {last_processed_commit_index} with last commit {:?} and {} unsent commits", last_commit, unsent_commits.len()); | |
| info!("Recovering commit observer after index {last_processed_commit_index} with last commit {} and {} unsent commits", last_commit.index(), unsent_commits.len()); |
| @@ -144,6 +144,7 @@ impl CommitObserver { | |||
| vec![] | |||
| }; | |||
|
|
|||
| info!("Sending commit {:?} during recovery", commit.index()); | |||
There was a problem hiding this comment.
Suggested change
| info!("Sending commit {:?} during recovery", commit.index()); | |
| info!("Sending commit {} during recovery", commit.index()); |
arun-koshy
approved these changes
Jul 25, 2024
suiwombat
pushed a commit
that referenced
this pull request
Sep 16, 2024
## Description * Increase timeout when waiting for consensus to start from `30s -> 60s`. Came across cases where commit recovery was taking a bit longer and might make sense to have a bit more tolerance. * Add more logs in consensus components and switch them to `info` - it's ok since those should be printed once per epoch * Make the consensus protocol choice log a `debug` . The method `get_consensus_protocol_in_epoch` is now being used from `get_max_accumulated_txn_cost_per_object_in_commit` which is called on every sequenced transaction leading to a very spammy log output: <img width="1459" alt="Screenshot 2024-07-25 at 11 37 09" src="https://github.com/user-attachments/assets/4971ae31-c033-46f6-bd16-bb6c4052640d"> ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
30s -> 60s. Came across cases where commit recovery was taking a bit longer and might make sense to have a bit more tolerance.info- it's ok since those should be printed once per epochdebug. The methodget_consensus_protocol_in_epochis now being used fromget_max_accumulated_txn_cost_per_object_in_commitwhich is called on every sequenced transaction leading to a very spammy log output:Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.