-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
indexer formal restore 1/N: restore packages and move objects #18886
Conversation
@gegaowp is attempting to deploy a commit to the Mysten Labs Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
bb56372
to
e6e0d8a
Compare
7c035f1
to
809a50d
Compare
809a50d
to
1822fa7
Compare
1822fa7
to
c1b5368
Compare
c1b5368
to
c098848
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@williampsmith would you be able to take a look at this as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to get some doc comments in here before we land it!
d0a9c84
to
49def34
Compare
49def34
to
4a3037e
Compare
4a3037e
to
0675b36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this LGTM. Curious to see how this performs, as it looks like you have a better parallelism construction in the object download portion. We should do the same on the sui side.
0675b36
to
d73f4af
Compare
d73f4af
to
69c4944
Compare
@williampsmith I benchmarked the restorer, the whole restorer to PG DB took about 3 hours while seems PG DB was the bottleneck. |
Description
first of the stack PR to restore indexer from sui archives & formal snapshot
Test plan
test locally with GCS buckets, local snapshot dir and local PG server
need to benchmark in the production env
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.