Feature gate arbitrary-precision from serde_json #18917
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Features in Rust are "infectious". In particular, the
arbitrary-precision
feature ofserde_json
is leading to issues downstream because of the known bugs:serde(tag = ..)
andserde(flatten)
serde-rs/json#505serde-arbitrary-precision
withoutserde-float
paupino/rust-decimal#602Therefore, my suggestion is to feature gate
arbitrary-precision
as done in this PR.Test plan
How did you test the new or updated feature?
cargo check
was run successfully.Release notes
It affects crates which have
serde_json
as dependency and which are using it from the workspace.Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.