Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move] Bugfix in Move model for enums #18938

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

tzakian
Copy link
Contributor

@tzakian tzakian commented Aug 9, 2024

Description

Fixes an issue around globalizing type signatures in the Move model for enums.

Test plan

Added tests to make sure we handle enums types in these cases.

@tzakian tzakian requested a review from a team August 9, 2024 11:38
Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 11:41am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Aug 9, 2024 11:41am
sui-kiosk ⬜️ Ignored (Inspect) Aug 9, 2024 11:41am
sui-typescript-docs ⬜️ Ignored (Inspect) Aug 9, 2024 11:41am

Copy link
Contributor

@stefan-mysten stefan-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this magic 🧙‍♂️ ?

@tzakian tzakian merged commit c79f53f into main Aug 9, 2024
48 checks passed
@tzakian tzakian deleted the tzakian/fix-enums-move-model-2 branch August 9, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants