Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[denylist] Fix sign check early return #18951

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Conversation

lxfind
Copy link
Contributor

@lxfind lxfind commented Aug 12, 2024

Description

Describe the changes or additions included in this PR.

Test plan

Will add test in a separate PR.

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

@lxfind lxfind requested a review from tnowacki August 12, 2024 15:23
Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 0:14am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 0:14am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 0:14am
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 0:14am

@lxfind
Copy link
Contributor Author

lxfind commented Aug 13, 2024

Added a transactional test

@lxfind lxfind enabled auto-merge (squash) August 13, 2024 00:06
@lxfind lxfind merged commit f644d71 into main Aug 13, 2024
48 checks passed
@lxfind lxfind deleted the denylist-v2-fix-sign-check branch August 13, 2024 03:08
suiwombat pushed a commit that referenced this pull request Sep 16, 2024
## Description 

Describe the changes or additions included in this PR.

## Test plan 

Will add test in a separate PR.
---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
- [ ] REST API:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants