[light-client] Fix light client rpc #19028
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
gdanezis
force-pushed
the
fix-light-client-rpc
branch
from
e90bf87
to
61e3489
Compare
gdanezis
requested review from
a team,
wlmyng,
stefan-mysten,
emmazzz,
suiwombat and
ronny-mysten
as code owners
gdanezis
force-pushed
the
light-client-fun
branch
from
a95c6fe
to
07c910c
Compare
gdanezis
force-pushed
the
fix-light-client-rpc
branch
from
61e3489
to
806bc7f
Compare
|
|
||
| // Parse the JSON response to get the last checkpoint of the epoch | ||
| let v: Value = serde_json::from_str(resp.as_str()).expect("Incorrect JSON response"); | ||
| let checkpoint_number = v["data"]["epoch"]["checkpoints"]["nodes"][0]["sequenceNumber"] |
There was a problem hiding this comment.
This may be a bit panick-y if one of these fields does not exist for some reason (like if the epoch was pruned). This is fine if we're intending this to be an example application, but if not, in some places we use cynic as a library to provide type-safe GraphQL queries in Rust -- where you will then be compelled to introduce Option<...> in the appropriate places where data might not exist, and check for it.
See this tool, for example, to fetch all packages:
https://github.com/MystenLabs/sui/blob/main/crates/sui-package-dump/src/query.rs
There was a problem hiding this comment.
Thanks for the great feedback, will look at cynic indeed.
There was a problem hiding this comment.
Feel free to also peek here: https://github.com/MystenLabs/sui-rust-sdk/tree/stefan/graphql_client_cynic/crates/sui-graphql-client
Docs on custom queries with cynic:
https://github.com/MystenLabs/sui-rust-sdk/tree/stefan/graphql_client_cynic/crates/sui-graphql-client#custom-queries
|
can we add |
gdanezis
force-pushed
the
fix-light-client-rpc
branch
from
531a402
to
d727fab
Compare
gdanezis
force-pushed
the
fix-light-client-rpc
branch
from
060dd04
to
4b9d020
Compare
gdanezis
force-pushed
the
fix-light-client-rpc
branch
from
4b9d020
to
c2c78d8
Compare
## Description Modernise the RPC used in the light client: - Use GraphQL to get the end-of-epoch checkpoint. - Use the supported Rust SDK to get objects and other info. - Use a generic object store, by default provided by Mysten, for the full checkpoint data. - Add a cache to package loader since we observed the same package downloaded multiple times. ## Test plan Existing unit tests, and manual CLI invocations.
Description
Modernise the RPC used in the light client:
Test plan
Existing unit tests, and manual CLI invocations.