indexer reader: derive dynamic field info #19099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
amnn
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
LGTM! Note that with this change JSON-RPC will fetch a dynamic object field's value object just to calculate its object ref, but doesn't offer a way to return its contents.
Not necessarily a blocker for this PR, but I just wanted to call that out from a query performance perspective, especially if an object has many dynamic object fields -- IIUC, now each one will introduce an extra DB roundtrip.
We have the similar issues in GraphQL, but there people can query for the object contents, and we batch the reads.
gegaowp
force-pushed
the
derive-df-info
branch
from
6a2d660
to
0dbbd46
Compare
suiwombat
pushed a commit
that referenced
this pull request
Sep 16, 2024
## Description title, with this pr and the corresponding pr in GQL, we can remove df_* from objects table except df_kind. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
title, with this pr and the corresponding pr in GQL, we can remove df_* from objects table except df_kind.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.