[pg indexer] split executors in non-colocated setup #19277
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
| ("primary".to_string(), primary_watermark), | ||
| ("object_snapshot".to_string(), object_snapshot_watermark), | ||
| ]), | ||
| progress_store.clone(), |
There was a problem hiding this comment.
So both executors will have the same progress store which has two watermarks? Are we still going to have the same issue if there are two watermarks?
There was a problem hiding this comment.
good question!
It's just a shim progress store with an underlying hashmap. It's mostly a no-op and is only used to initialize the system.
It's safe to have more entries than needed.
The actual read from it and setup happens during the executor.register call
| executors.push((executor, exit_receiver)); | ||
| exit_senders.push(exit_sender); | ||
|
|
||
| if config.sources.data_ingestion_path.is_none() { |
There was a problem hiding this comment.
Does data_ingestion_path being none imply colocation or not colocation? We should start a separate executor when things are not colocated. A comment would help here. Thanks!
There was a problem hiding this comment.
data_ingestion_path being none automatically implies non-colocated setup
phoenix-o
force-pushed
the
di_pg_indexer_executors
branch
from
ca872c9
to
2f243c6
Compare
phoenix-o
force-pushed
the
di_pg_indexer_executors
branch
from
2f243c6
to
8f15bce
Compare
## Description conditionally split executors for the PG indexer. This will prevent the object snapshot pipeline from affecting the progress of the primary workflow in non-colocated setups. For colocated setups, we still need to utilize a single executor --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
Description
conditionally split executors for the PG indexer.
This will prevent the object snapshot pipeline from affecting the progress of the primary workflow in non-colocated setups.
For colocated setups, we still need to utilize a single executor
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.